Summary: | Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2011-08-02 16:55:23 PDT
(In reply to comment #0) > It looks like load/saveSessionSetting is only used in one place, for "debugger-enabled". > In fact, that has been superseded by the WebInspector.setting localStorage setting. It > looks we can just remove these functions: > > - JS: InspectorFrontendHostStub, ScriptsPanel.js usage > - Inspector: InspectorFrontendHost + Client > - WebKit 1 Ports: cf, mac, win and hashmap instance variable You are probably right: we now have persistent localStorage settings and runtime cookie. This code should vanish. Do you have a patch pending? Sure I can make a patch. I just had to update my Open Source checkout. After a week or two it takes so long I looked at other things and lost track of this! I'll assign this to myself. Created attachment 102796 [details]
[PATCH] Remove the stale code
Comment on attachment 102796 [details] [PATCH] Remove the stale code Clearing flags on attachment: 102796 Committed r92300: <http://trac.webkit.org/changeset/92300> All reviewed patches have been landed. Closing bug. |