Summary: | Chromium Mac: Fix position of search tickmarks | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sailesh Agrawal <sail> | ||||||
Component: | New Bugs | Assignee: | Sailesh Agrawal <sail> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | jamesr, thakis, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Sailesh Agrawal
2011-08-02 14:59:15 PDT
Created attachment 102704 [details]
Patch
Comment on attachment 102704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102704&action=review > Source/WebCore/ChangeLog:8 > + https://bugs.webkit.org/show_bug.cgi?id=65575 > + > + This change adjusts the position of search tickmarks so that they are correctly centered. > + > + Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better. You need a 'Reviewed by' line. Is this behavior different from the mac scrollbar theme? > Is this behavior different from the mac scrollbar theme?
Tickmarks are specific to chromium, the mac theme doesn't have them.
Created attachment 102827 [details]
Patch
Comment on attachment 102704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102704&action=review >> Source/WebCore/ChangeLog:8 >> + Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better. > > You need a 'Reviewed by' line. Is this behavior different from the mac scrollbar theme? Fixed. Comment on attachment 102827 [details]
Patch
The Reviewed by line really should be just below the bug URL, but whatever
Comment on attachment 102827 [details] Patch Clearing flags on attachment: 102827 Committed r92319: <http://trac.webkit.org/changeset/92319> All reviewed patches have been landed. Closing bug. |