Bug 65561

Summary:

Missing null check in WebViewImpl::selectionRange

Product:

WebKit

Reporter:

Varun Jain <varunjain>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fishd, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Varun Jain 2011-08-02 12:31:34 PDT

Missing null check in WebViewImpl::selectionRange

Comment 1 Varun Jain 2011-08-02 12:32:25 PDT

Created attachment 102681 [details]
Patch

Comment 2 Darin Fisher (:fishd, Google) 2011-08-02 13:02:44 PDT

Comment on attachment 102681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102681&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:1534
> +      return false;

nit: indentation should be 4 spaces

Comment 3 Varun Jain 2011-08-02 13:08:55 PDT

Created attachment 102688 [details]
Patch

Comment 4 Varun Jain 2011-08-02 13:09:15 PDT

(In reply to comment #2)
> (From update of attachment 102681 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102681&action=review
> 
> > Source/WebKit/chromium/src/WebViewImpl.cpp:1534
> > +      return false;
> 
> nit: indentation should be 4 spaces

Done

Comment 5 WebKit Review Bot 2011-08-02 15:19:37 PDT

Comment on attachment 102688 [details]
Patch

Clearing flags on attachment: 102688

Committed r92240: <http://trac.webkit.org/changeset/92240>

Comment 6 WebKit Review Bot 2011-08-02 15:19:41 PDT

All reviewed patches have been landed.  Closing bug.