Bug 65545 – [Qt][WK2] Add initial support for synthetic click on WebKit2

• Component: UI Events
• Status: RESOLVED INVALID

[Benjamin Poulain]

When a touch event is not used by a page, and is not part of a gesture, we might have some other use for it... like clicking :)

[Benjamin Poulain]

Created attachment 102664 [details]
Patch

[Benjamin Poulain]

I tried to keep this patch nice and simple, I will grow QtTapHandler in follow up patches.
I am not a fan of the name QtTapHandler. Suggestions for a better name are welcome.

Chromium has its own implementation of synthetic click InnerGestureRecognizer::dispatchSyntheticClick(). When/If my patch goes in, I'll refactor InnerGestureRecognizer to use EventHandler directly. I did not do it here to keep things simple.

[Antonio Gomes]

Comment on attachment 102664 [details]
Patch

LGTM.

Does it need unit tests?

[Benjamin Poulain]

(In reply to comment #3)
> Does it need unit tests?

Yep, we really need to add tests at some point. 

But unfortunately we do not have support for the WebKitTestRunner for the touch webview yet (the view barely work at the moment).

[Benjamin Poulain]

Comment on attachment 102664 [details]
Patch

This needs to be redone due to https://bugs.webkit.org/show_bug.cgi?id=65044

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.