Bug 65533 – Web Inspector [JSC]: Enable initiator column in network panel.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Vsevolod Vlasov]

Enable initiator column in network panel.

Initiator column in network panel is disabled for JSC because stack trace is not available for resource triggered by javascript.

[Vsevolod Vlasov]

Initiator column was removed from network panel in JSC in https://bugs.webkit.org/show_bug.cgi?id=65534

[sfa]

Created attachment 151142 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 151142 [details]
Patch

This feature should be tested. Please make sure your patch enables http/tests/inspector/network/network-initiator.html. It is currently disabled (and broken?). :(
See https://bugs.webkit.org/show_bug.cgi?id=85038 also.

[sfa]

Thanks for the pointer to this test but when running it, it fails on the size=200 static CSS image request. There is nothing added to the network log requests list for this image. Here is a dump of the list when searching for size=200...

find(/size=200/) http://127.0.0.1:8000/inspector/network/network-initiator.html
find(/size=200/) http://127.0.0.1:8000/inspector/network/resources/initiator.css
find(/size=200/) http://127.0.0.1:8000/inspector/inspector-test.js
find(/size=200/) http://127.0.0.1:8000/inspector/network-test.js
find(/size=200/) http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&random=1&size=100
find(/size=200/) http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&random=1&size=300
find(/size=200/) http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&random=1&size=400

I'm not qualified to fix the static CSS not adding the image request to the list so the question comes up, what should we do?

(1) hold up this change until the static CSS image request regression is fixed
(2) make a copy and tweak this test to remove the static CSS case effectively adding a test)
(3) ???

I'm partial to (2) and open to suggestions on how to change the test (I can provide my current version). Thoughts?

[sfa]

I've confirmed that disabling caching in http://trac.webkit.org/changeset/115379/ allows the size=200 image to be recorded in the list so the regression is confirmed.

[sfa]

Created attachment 152306 [details]
Patch

[sfa]

Submitted a patch for my option (2), I couldn't get a chromium test output, may need help acquiring the expected output.

[Vsevolod Vlasov]

Here is how the test could be fixed:
LayoutTests/http/tests/inspector/inspector-test.js has an Inspector.reloadPage() method that is used to reload the page in the our test. It uses PageAgent.reload() method. The parameter false passed to it means "soft reload" while in this case we need a "hard reload". 

InspectorTest.hardReloadPage() should fix it if you put the following code to inspexctor-test.js:

InspectorTest.hardReloadPage = function(callback)
{
    InspectorTest._innerReloadPage(true, callback);
}

InspectorTest.reloadPage = function(callback)
{
    InspectorTest._innerReloadPage(false, callback);
}

InspectorTest._innerReloadPage = function(hardReload, callback)
{
    InspectorTest._pageLoadedCallback = InspectorTest.safeWrap(callback);

    if (WebInspector.panels.network)
        WebInspector.panels.network._reset();
    PageAgent.reload(hardReload);
}

[sfa]

Created attachment 153821 [details]
Patch

[WebKit Review Bot]

Comment on attachment 153821 [details]
Patch

Attachment 153821 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13329125

New failing tests:
http/tests/inspector/network/network-initiator.html

[WebKit Review Bot]

Created attachment 153838 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[sfa]

Created attachment 153848 [details]
Patch

[Vsevolod Vlasov]

Thank you for fixing this.

[WebKit Review Bot]

Comment on attachment 153848 [details]
Patch

Clearing flags on attachment: 153848

Committed r123452: <http://trac.webkit.org/changeset/123452>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.