Summary: | Web Inspector: there should be a way to tell what properties are non-enumerable when expanding objects. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, ossy, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 65905 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Pavel Feldman
2011-08-01 23:21:00 PDT
Created attachment 103336 [details]
Patch
Created attachment 103337 [details]
[IMAGE] Looks with patch applied.
Attachment 103336 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:88: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.h:73: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.cpp:112: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:73: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Total errors found: 4 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 103336 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103336&action=review > Source/WebCore/inspector/Inspector.json:245 > + { "name": "get", "$ref": "RemoteObject", "description": "A function which serves as a getter for the property, or <code>undefined</code> if there is no getter (accessor descriptors only)." }, get -> getter > Source/WebCore/inspector/Inspector.json:246 > + { "name": "set", "$ref": "RemoteObject", "description": "A function which serves as a setter for the property, or <code>undefined</code> if there is no setter (accessor descriptors only)." }, set -> setter > Source/WebCore/inspector/Inspector.json:296 > + { "name": "ownProperties", "optional": true, "type": "boolean", "description": "If true, returns properties belonging only to the element itself, not to its prototype chain." } ownProperties -> ownPropertiesOnly ? > Source/WebCore/inspector/front-end/RemoteObject.js:230 > + this.writable = descriptor ? !!descriptor.writable : true; Please remove !! before descriptor.writable (In reply to comment #4) > (From update of attachment 103336 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=103336&action=review > > > Source/WebCore/inspector/Inspector.json:245 > > + { "name": "get", "$ref": "RemoteObject", "description": "A function which serves as a getter for the property, or <code>undefined</code> if there is no getter (accessor descriptors only)." }, > > get -> getter > I agree here, but I think sticking with the ECMA spec is more important. > > Source/WebCore/inspector/Inspector.json:246 > > + { "name": "set", "$ref": "RemoteObject", "description": "A function which serves as a setter for the property, or <code>undefined</code> if there is no setter (accessor descriptors only)." }, > > set -> setter ditto > > > Source/WebCore/inspector/Inspector.json:296 > > + { "name": "ownProperties", "optional": true, "type": "boolean", "description": "If true, returns properties belonging only to the element itself, not to its prototype chain." } > > ownProperties -> ownPropertiesOnly ? > I think present way is more clear, see the documentation field. > > Source/WebCore/inspector/front-end/RemoteObject.js:230 > > + this.writable = descriptor ? !!descriptor.writable : true; > > Please remove !! before descriptor.writable Done. Committed r92670: <http://trac.webkit.org/changeset/92670> It broke 3 inspector tests on all bot: - http://build.webkit.org/results/Leopard%20Intel%20Debug%20%28Tests%29/r92670%20%2832897%29/results.html - http://build.webkit.org/results/Windows%207%20Release%20%28Tests%29/r92670%20%2815313%29/results.html - http://build.webkit.org/results/Qt%20Linux%20Release/r92670%20%2836302%29/results.html Reopen, because it was rolled out by https://trac.webkit.org/changeset/92671 Committed r92765: <http://trac.webkit.org/changeset/92765> |