Bug 65506

Summary: Improve const-correctness in CSS code: type information methods
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: CSSAssignee: Roland Steiner <rolandsteiner>
Status: RESOLVED FIXED    
Severity: Minor CC: bdakin, dglazkov, dominicc, hayato, hyatt, morrita, noel.gordon, simon.fraser, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 65598    
Bug Blocks:    
Attachments:
Description Flags
Patch simon.fraser: review+, webkit.review.bot: commit-queue-

Roland Steiner
Reported 2011-08-01 19:24:31 PDT
Type information methods defined in StyleBase ("is...()" methods) and CSSRule ("type()" method) should be const, and - in the case of type() - return the enum type rather than a generic unsigned int.
Attachments
Patch (11.24 KB, patch)
2011-08-01 19:38 PDT, Roland Steiner 		simon.fraser: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2011-08-01 19:38:30 PDT
Created attachment 102613 [details] Patch
WebKit Review Bot
Comment 2 2011-08-01 19:59:40 PDT
Comment on attachment 102613 [details] Patch Attachment 102613 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9285611
WebKit Review Bot
Comment 3 2011-08-02 00:41:21 PDT
Comment on attachment 102613 [details] Patch Attachment 102613 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9289556
Roland Steiner
Comment 4 2011-08-03 00:47:40 PDT
Build errors on Chromium bots should be fixed by patch to https://bugs.webkit.org/show_bug.cgi?id=65598.
Roland Steiner
Comment 5 2011-08-04 23:05:08 PDT
Committed r92448: <http://trac.webkit.org/changeset/92448>
noel gordon
Comment 7 2011-08-06 00:15:06 PDT
Tests went green eventually.
Note You need to log in before you can comment on or make changes to this bug.