Bug 65498

Summary: [chromium] Fix unresolved symbols error when linking to libwebkit.dylib
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Nico Weber
Reported 2011-08-01 17:12:28 PDT
[chromium] Fix unresolved symbols error when linking to libwebkit.dylib
Attachments
Patch (1.99 KB, patch)
2011-08-01 17:13 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2011-08-01 17:13:17 PDT
Created attachment 102595 [details] Patch
Nico Weber
Comment 2 2011-08-01 17:30:19 PDT
I can has stamp? Mento says LG over email.
Dimitri Glazkov (Google)
Comment 3 2011-08-02 09:12:15 PDT
Comment on attachment 102595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102595&action=review > Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh:89 > + # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr Please avoid using the word "lazy". It sounds demeaning. Perhaps "thoughtful" or "well-timed"?
Nico Weber
Comment 4 2011-08-02 09:19:16 PDT
(In reply to comment #3) > > Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh:89 > > + # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr > > Please avoid using the word "lazy". It sounds demeaning. Perhaps "thoughtful" or "well-timed"? But it's "non_lazy". Isn't the negation of a demeaning word more world-improving than the negation of a kinder word?
Dimitri Glazkov (Google)
Comment 5 2011-08-02 09:20:37 PDT
(In reply to comment #4) > (In reply to comment #3) > > > Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh:89 > > > + # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr > > > > Please avoid using the word "lazy". It sounds demeaning. Perhaps "thoughtful" or "well-timed"? > > But it's "non_lazy". Isn't the negation of a demeaning word more world-improving than the negation of a kinder word? Ah. I missed that. LGTM.
WebKit Review Bot
Comment 6 2011-08-02 10:33:59 PDT
Comment on attachment 102595 [details] Patch Clearing flags on attachment: 102595 Committed r92203: <http://trac.webkit.org/changeset/92203>
WebKit Review Bot
Comment 7 2011-08-02 10:34:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.