| Summary: | [chromium] Fix unresolved symbols error when linking to libwebkit.dylib | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nico Weber <thakis> | ||||
| Component: | New Bugs | Assignee: | Nico Weber <thakis> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dglazkov, jamesr, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Nico Weber
2011-08-01 17:12:28 PDT
Created attachment 102595 [details]
Patch
I can has stamp? Mento says LG over email. Comment on attachment 102595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102595&action=review > Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh:89 > + # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr Please avoid using the word "lazy". It sounds demeaning. Perhaps "thoughtful" or "well-timed"? (In reply to comment #3) > > Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh:89 > > + # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr > > Please avoid using the word "lazy". It sounds demeaning. Perhaps "thoughtful" or "well-timed"? But it's "non_lazy". Isn't the negation of a demeaning word more world-improving than the negation of a kinder word? (In reply to comment #4) > (In reply to comment #3) > > > Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh:89 > > > + # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr > > > > Please avoid using the word "lazy". It sounds demeaning. Perhaps "thoughtful" or "well-timed"? > > But it's "non_lazy". Isn't the negation of a demeaning word more world-improving than the negation of a kinder word? Ah. I missed that. LGTM. Comment on attachment 102595 [details] Patch Clearing flags on attachment: 102595 Committed r92203: <http://trac.webkit.org/changeset/92203> All reviewed patches have been landed. Closing bug. |