Bug 65494

Summary: RenderObject::computeRectForRepaint and clippedOverflowRectForRepaint should be const
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Trivial CC: darin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Trivial const-ness change. none

Julien Chaffraix
Reported 2011-08-01 15:36:31 PDT
To test some code, I wanted to call those 2 from a const method and could not without an ugly cast. Those methods return a copy of the solution and are not expected to modify the internal state so I think they satisfy the definition of const-ness as discussed on the ML. Trivial patch forthcoming.
Attachments
Trivial const-ness change. (38.70 KB, patch)
2011-08-01 15:44 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2011-08-01 15:44:39 PDT
Created attachment 102576 [details] Trivial const-ness change.
Darin Adler
Comment 2 2011-08-02 17:54:25 PDT
Comment on attachment 102576 [details] Trivial const-ness change. OK, as long as everything called in these functions is also const.
WebKit Review Bot
Comment 3 2011-08-02 18:58:21 PDT
Comment on attachment 102576 [details] Trivial const-ness change. Clearing flags on attachment: 102576 Committed r92252: <http://trac.webkit.org/changeset/92252>
WebKit Review Bot
Comment 4 2011-08-02 18:58:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.