[Chromium] WebSQLDatabase version handling is broken in multi-process browsers.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Michael Nordman]

[Chromium] WebSQLDatabase version handling is broken in multi-process browsers.

The WebCore::AbstractDatabase class maintains a global in-memory map of the version numbers associated with open database files. That map is not reliable in a multi-process system.

[Michael Nordman]

Created attachment 102567 [details]
version handling

[WebKit Review Bot]

Attachment 102567 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/storage/AbstractDatabase.h:101:  The parameter name "version" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/storage/AbstractDatabase.h:104:  The parameter name "version" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/storage/AbstractDatabase.cpp:354:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Nordman]

Created attachment 102569 [details]
version handling - style fix

[Early Warning System Bot]

Comment on attachment 102569 [details]
version handling - style fix

Attachment 102569 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9290524

[Michael Nordman]

Created attachment 102577 [details]
version handling - fix unused local var error

[Michael Nordman]

Committed r92155: <http://trac.webkit.org/changeset/92155>