Bug 65486 - [Chromium] WebSQLDatabase version handling is broken in multi-process browsers.
Summary: [Chromium] WebSQLDatabase version handling is broken in multi-process browsers.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Nordman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-01 14:27 PDT by Michael Nordman
Modified: 2011-08-01 17:22 PDT (History)
1 user (show)

See Also:


Attachments
version handling (23.25 KB, patch)
2011-08-01 15:10 PDT, Michael Nordman
no flags Details | Formatted Diff | Diff
version handling - style fix (23.23 KB, patch)
2011-08-01 15:18 PDT, Michael Nordman
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
version handling - fix unused local var error (23.24 KB, patch)
2011-08-01 15:45 PDT, Michael Nordman
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Nordman 2011-08-01 14:27:53 PDT
[Chromium] WebSQLDatabase version handling is broken in multi-process browsers.

The WebCore::AbstractDatabase class maintains a global in-memory map of the version numbers associated with open database files. That map is not reliable in a multi-process system.
Comment 1 Michael Nordman 2011-08-01 15:10:57 PDT
Created attachment 102567 [details]
version handling
Comment 2 WebKit Review Bot 2011-08-01 15:13:10 PDT
Attachment 102567 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/storage/AbstractDatabase.h:101:  The parameter name "version" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/storage/AbstractDatabase.h:104:  The parameter name "version" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/storage/AbstractDatabase.cpp:354:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Nordman 2011-08-01 15:18:34 PDT
Created attachment 102569 [details]
version handling - style fix
Comment 4 Early Warning System Bot 2011-08-01 15:25:03 PDT
Comment on attachment 102569 [details]
version handling - style fix

Attachment 102569 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9290524
Comment 5 Michael Nordman 2011-08-01 15:45:07 PDT
Created attachment 102577 [details]
version handling - fix unused local var error
Comment 6 Michael Nordman 2011-08-01 17:22:22 PDT
Committed r92155: <http://trac.webkit.org/changeset/92155>