Bug 65476

Summary: Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, steveblock, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch yurys: review+, webkit.review.bot: commit-queue-

Description Andrey Kosyakov 2011-08-01 10:09:04 PDT
Somehow, the test for webInspector.inspectedPage.reload() added in Bug 51485 wasn't landed. This lead to webInspector.inspectedPage.reload() being eventaully broken by a change in inspector backend interface (PageAgent.setUserAgentOverride() -> NetworkAgent.setUserAgentOverride()).
Comment 1 Andrey Kosyakov 2011-08-01 10:28:10 PDT
Created attachment 102533 [details]
patch

- Fixed webInspector.inspectedPage.reload()
- Broguht back tests for the above
- Removed redundant user-agent override from FrameLoader::loadResourceSynchronously(), this should happen indirectly via a call to addExtraFieldsToSubresourceRequest()
Comment 2 WebKit Review Bot 2011-08-01 11:12:31 PDT
Comment on attachment 102533 [details]
patch

Attachment 102533 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9290455

New failing tests:
http/tests/inspector/extensions-useragent.html
Comment 3 Andrey Kosyakov 2011-11-30 09:37:04 PST
Manually committed r92187: http://trac.webkit.org/changeset/92187