Summary: | [Qt] OpenGLShims does not build on ARM | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
Component: | Platform | Assignee: | Benjamin Poulain <benjamin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | noam, rectalogic, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 57154 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Benjamin Poulain
2011-08-01 06:20:35 PDT
Created attachment 102511 [details]
Patch
This patch is just a build fix. To get everything right, the code using glBlitFramebuffer and glRenderbufferStorageMultisample should check if the functions exist at runtime. Alternatively, the code using those function could be #ifdefined as well but that would spread in a rather ugly way. Redefining: typedef char GLchar; seems to work on GCC but I doubt that is portable. If someone has a better idea, I'd be glad to update that line :) Comment on attachment 102511 [details] Patch Attachment 102511 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9289319 Created attachment 102513 [details]
Patch
Comment on attachment 102513 [details] Patch Clearing flags on attachment: 102513 Committed r92130: <http://trac.webkit.org/changeset/92130> All reviewed patches have been landed. Closing bug. |