Summary: | DFG JIT verbose mode provides no details about predictions | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough, fpizlo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2011-07-29 14:03:54 PDT
Created attachment 102394 [details]
the patch
Attachment 102394 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGGraph.cpp:138: Missing space after , [whitespace/comma] [3]
Source/JavaScriptCore/dfg/DFGGraph.cpp:139: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 102396 [details]
the patch (fix style, passes tests)
Comment on attachment 102396 [details]
the patch (fix style, passes tests)
Sorry to be a pain, but (1) this should be ndef NDEBUG only code. If you find this useful to have in a header to be able to use easily when debugging, then I'd wrap in #ifndef NDEBUG, but you could also consider moving to the NDEBUG section of the .cpp & marking as static. Also, code on the same lines as labels doesn't match the coding style, there should really be newlines in here.
Created attachment 102401 [details]
the patch (fix review)
Comment on attachment 102401 [details] the patch (fix review) Clearing flags on attachment: 102401 Committed r92038: <http://trac.webkit.org/changeset/92038> All reviewed patches have been landed. Closing bug. |