Bug 65389

Summary:

DFG JIT verbose mode provides no details about predictions

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, fpizlo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none
the patch (fix style, passes tests)	barraclough: review-
the patch (fix review)	none

Filip Pizlo

Reported 2011-07-29 14:03:54 PDT

One tool that the DFG JIT provides for debugging the JIT itself is verbose mode, which results in an IR dump of the procedure being compiled. But this IR dump does not print any information about predictions.

Attachments
the patch (2.29 KB, patch) 2011-07-29 14:07 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (fix style, passes tests) (2.28 KB, patch) 2011-07-29 14:18 PDT, Filip Pizlo	barraclough: review-	Details Formatted Diff Diff
the patch (fix review) (2.36 KB, patch) 2011-07-29 15:02 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2011-07-29 14:07:39 PDT

Created attachment 102394 [details] the patch

WebKit Review Bot

Comment 2 2011-07-29 14:10:37 PDT

Attachment 102394 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGGraph.cpp:138: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/dfg/DFGGraph.cpp:139: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 3 2011-07-29 14:18:26 PDT

Created attachment 102396 [details] the patch (fix style, passes tests)

Gavin Barraclough

Comment 4 2011-07-29 14:35:27 PDT

Comment on attachment 102396 [details] the patch (fix style, passes tests) Sorry to be a pain, but (1) this should be ndef NDEBUG only code. If you find this useful to have in a header to be able to use easily when debugging, then I'd wrap in #ifndef NDEBUG, but you could also consider moving to the NDEBUG section of the .cpp & marking as static. Also, code on the same lines as labels doesn't match the coding style, there should really be newlines in here.

Filip Pizlo

Comment 5 2011-07-29 15:02:29 PDT

Created attachment 102401 [details] the patch (fix review)

WebKit Review Bot

Comment 6 2011-07-29 19:00:51 PDT

Comment on attachment 102401 [details] the patch (fix review) Clearing flags on attachment: 102401 Committed r92038: <http://trac.webkit.org/changeset/92038>

WebKit Review Bot

Comment 7 2011-07-29 19:00:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.