Bug 65375
| Summary: | Style checker should flag usage of 'unsigned int' | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mihnea Ovidenie <mihnea> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ap, jchaffraix, levin, llango.u-szeged |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mihnea Ovidenie
Style checker should report the occurrences of 'unsigned int'. Instead of 'unsigned int' we should use only 'unsigned'.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
A patch in bug 65176 prompted this bug report.
David Levin
For anyone interested, I'm happy to coach people on how to add rules to the style checker :).
Mihnea Ovidenie
(In reply to comment #2)
> For anyone interested, I'm happy to coach people on how to add rules to the style checker :).
I am interested to learn about style checker and tools, i'll catch you on #webkit.
Julien Chaffraix
FYI, I did some very simple grepping to see our usage. Here are the results for Source/WebCore/
$ grep -R "unsigned " .|grep -v "unsigned short"|grep -v "unsigned int"|grep -v "unsigned char"|grep -v "unsigned long"|grep -v ChangeLog|wc -l
5085
$ grep -R "unsigned int" .|grep -v ChangeLog|wc -l
877
Those expressions are very rough but it still looks like it is a fairly wide-spread unwritten rule.
László Langó
http://trac.webkit.org/changeset/128545
*** This bug has been marked as a duplicate of bug 96693 ***