Summary: | WebSocket: Rename SocketStreamHandleClient member functions | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yuta Kitamura <yutak> | ||||||||
Component: | WebCore Misc. | Assignee: | Yuta Kitamura <yutak> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, ap, tkent, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 65249 | ||||||||||
Attachments: |
|
Description
Yuta Kitamura
2011-07-29 06:52:32 PDT
Created attachment 102357 [details]
Patch
Comment on attachment 102357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102357&action=review > Source/WebCore/ChangeLog:3 > + WebSocket: Rename SocketStreamHandleClient methods nit: In C++, they are called "member function", not "method". > Source/WebCore/ChangeLog:8 > + Rename SocketStreamHandleClient methods to avoid conflict of the names of FileReaderLoaderClient methods. ditto. > Source/WebCore/websockets/WebSocketChannel.h:68 > + // SocketStreamHandleClient methods. ditto. > Source/WebKit/chromium/ChangeLog:3 > + WebSocket: Rename SocketStreamHandleClient methods ditto. Created attachment 102480 [details]
Patch for landing
Created attachment 102482 [details]
Patch for landing
Comment on attachment 102482 [details] Patch for landing Clearing flags on attachment: 102482 Committed r92102: <http://trac.webkit.org/changeset/92102> All reviewed patches have been landed. Closing bug. |