Bug 65368

Summary: [EFL] Implement declared but missing functions.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch2
none
Patch none

Ryuan Choi
Reported 2011-07-29 04:52:32 PDT
I found that implementation of Cursor::operator=, localizedString was missing although it was declared. Compiler seems to ignore because WebKit/Efl doesn't use. (but WebKit2 use them.)
Attachments
Patch (2.08 KB, patch)
2011-07-29 04:59 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
patch2 (2.09 KB, patch)
2011-07-29 05:29 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (1.94 KB, patch)
2011-10-04 02:03 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-07-29 04:59:12 PDT
Created attachment 102347 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-07-29 05:06:47 PDT
> Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:550 > + return String::fromUTF8(key); Passing strlen(key) as a second parameter to fromUTF8 should make things a bit faster on WTFString's side.
Ryuan Choi
Comment 3 2011-07-29 05:29:36 PDT
Created attachment 102350 [details] patch2
Ryuan Choi
Comment 4 2011-07-29 05:30:36 PDT
(In reply to comment #2) > > Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:550 > > + return String::fromUTF8(key); > > Passing strlen(key) as a second parameter to fromUTF8 should make things a bit faster on WTFString's side. Done.
Raphael Kubo da Costa (:rakuco)
Comment 5 2011-07-29 05:35:22 PDT
r+ from my side.
Gyuyoung Kim
Comment 6 2011-08-01 23:07:04 PDT
Comment on attachment 102350 [details] patch2 LGTM
Ryuan Choi
Comment 7 2011-10-04 02:03:11 PDT
Created attachment 109596 [details] Patch
WebKit Review Bot
Comment 8 2011-10-04 03:06:46 PDT
Comment on attachment 109596 [details] Patch Clearing flags on attachment: 109596 Committed r96581: <http://trac.webkit.org/changeset/96581>
WebKit Review Bot
Comment 9 2011-10-04 03:06:50 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 10 2011-10-04 09:31:51 PDT
Thanks for the fixes. I didn’t notice the EFL build breakage.
Gyuyoung Kim
Comment 11 2011-10-04 16:54:55 PDT
(In reply to comment #10) > Thanks for the fixes. I didn’t notice the EFL build breakage. No problem. please consider EFL build in future. :-)
Note You need to log in before you can comment on or make changes to this bug.