Bug 65355

Summary: Remove LegacyDefaultOptionalArguments flag from geolocation IDL files
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2011-07-28 19:36:18 PDT
As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates geolocation-related files. This patch changes behavior -- it makes the geolocation methods match the spec for which arguments are required and which are optional, and (newly) throw TypeError if required arguments are missing.
Attachments
Patch (2.93 KB, patch)
2011-07-28 19:40 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (2.93 KB, patch)
2011-08-03 14:43 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-07-28 19:40:24 PDT
Created attachment 102326 [details] Patch
Adam Barth
Comment 2 2011-07-28 22:45:02 PDT
Comment on attachment 102326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102326&action=review > Source/WebCore/page/PositionErrorCallback.idl:-28 > - LegacyDefaultOptionalArguments, We can probably nuke this attribute on all Callback=FunctionOnly interfaces.
Adam Barth
Comment 3 2011-08-02 13:48:31 PDT
Comment on attachment 102326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102326&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Actually, this line will cause the commit-queue to bounce your patch.
Mark Pilgrim (Google)
Comment 4 2011-08-03 14:43:21 PDT
Created attachment 102830 [details] Patch
WebKit Review Bot
Comment 5 2011-08-03 16:01:58 PDT
Comment on attachment 102830 [details] Patch Clearing flags on attachment: 102830 Committed r92323: <http://trac.webkit.org/changeset/92323>
WebKit Review Bot
Comment 6 2011-08-03 16:02:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.