Remove LegacyDefaultOptionalArguments flag from geolocation IDL files

• Component: New Bugs
• Status: RESOLVED FIXED

[Mark Pilgrim (Google)]

As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates geolocation-related files. This patch changes behavior -- it makes the geolocation methods match the spec for which arguments are required and which are optional, and (newly) throw TypeError if required arguments are missing.

[Mark Pilgrim (Google)]

Created attachment 102326 [details]
Patch

[Adam Barth]

Comment on attachment 102326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102326&action=review

> Source/WebCore/page/PositionErrorCallback.idl:-28
> -        LegacyDefaultOptionalArguments,

We can probably nuke this attribute on all Callback=FunctionOnly interfaces.

[Adam Barth]

Comment on attachment 102326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102326&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Actually, this line will cause the commit-queue to bounce your patch.

[Mark Pilgrim (Google)]

Created attachment 102830 [details]
Patch

[WebKit Review Bot]

Comment on attachment 102830 [details]
Patch

Clearing flags on attachment: 102830

Committed r92323: <http://trac.webkit.org/changeset/92323>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.