Bug 65342

Summary:

Implement support for positioned floats in the FloatingObject list of RenderBlock

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	sam: review+

Description Dave Hyatt 2011-07-28 13:50:00 PDT

Implement support for positioned floats in the FloatingObject list of RenderBlock.

Comment 1 Dave Hyatt 2011-07-28 14:26:55 PDT

Created attachment 102299 [details]
Patch

Comment 2 Dave Hyatt 2011-07-28 15:04:30 PDT

Created attachment 102303 [details]
Patch

Comment 3 Sam Weinig 2011-07-29 12:37:43 PDT

Comment on attachment 102303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102303&action=review

> Source/WebCore/rendering/RenderBlock.cpp:1364
> +        setChildNeedsLayout(true, false);
> +        layoutBlock(false, pageLogicalHeight, PositionedFloatLayoutPass);
> +    } else
> +        setNeedsLayout(false);

We really need to updated these to not be bools at some point.

> Source/WebCore/rendering/RenderBlock.cpp:1443
> +        if (r->m_isDescendant && !r->m_renderer->isPositioned())

It might be helpful to indicate in a comment why you can ignore positioned objects here (e.g. where it is actually handled).

Comment 4 Dave Hyatt 2011-07-29 13:19:33 PDT

Landed in r92004.

Comment 5 Daniel Bates 2011-07-30 23:32:00 PDT

This broke the Chromium Linux Release Flexbox buildbot (non-core):
<http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Flexbox%29/builds/1821/steps/compile-webkit/logs/stdio>.

Committed build fix in <http://trac.webkit.org/changeset/92072>.