Summary: | [Qt] [WK2] Expose web view classes to QML | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||||
Component: | WebKit Qt | Assignee: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, kling, menard | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Caio Marcelo de Oliveira Filho
2011-07-28 13:16:38 PDT
Created attachment 102292 [details]
Patch
Comment on attachment 102292 [details]
Patch
After talking in #qtwebkit with Benjamin and others, I'm working on adding tests for the QML plugin as well.
Created attachment 102713 [details]
Patch
Benjamin, could you take a look? This commit depends on https://qt.gitorious.org/qt/qtdeclarative/merge_requests/1, I sent an email for QML devs that might want to merge, but feel welcome to take a look there too :-) Comment on attachment 102713 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102713&action=review Looks great > Source/WebKit2/UIProcess/API/qt/qmlplugin/plugin.cpp:37 > + qmlRegisterUncreatableType<QTouchWebPage>(uri, 5, 0, "TouchWebPage", QString::fromLatin1("Cannot create separate instance of TouchWebPage, use TouchWebView")); QString::fromLatin1() -> QObject::tr(). Comment on attachment 102713 [details]
Patch
yeahhhh good stuff
(In reply to comment #4) > This commit depends on https://qt.gitorious.org/qt/qtdeclarative/merge_requests/1, I sent an email for QML devs that might want to merge, but feel welcome to take a look there too :-) For the record, the fix was already merged in qt-declarative:master https://qt.gitorious.org/qt/qtdeclarative/commit/73aa113181fa2295729d24317c187661f740b898 Committed r92277: <http://trac.webkit.org/changeset/92277> |