Bug 65304

Summary: [Chromium] Add form() function to access parent WebFormElement from WebFormControlElement.
Product: WebKit Reporter: Naoki Takano <honten>
Component: New BugsAssignee: Naoki Takano <honten>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, honten, isherman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Naoki Takano
Reported 2011-07-27 23:24:33 PDT
[Chromium] Add form() function to access parent WebFormElement from WebFormControlElement.
Attachments
Patch (2.74 KB, patch)
2011-07-27 23:27 PDT, Naoki Takano 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Naoki Takano
Comment 1 2011-07-27 23:27:00 PDT
Created attachment 102229 [details] Patch
Naoki Takano
Comment 2 2011-07-27 23:32:49 PDT
Please review.
Ilya Sherman
Comment 3 2011-07-28 02:19:38 PDT
Comment on attachment 102229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102229&action=review Looks ok to me, but I am not a WebKit reviewer. > Source/WebKit/chromium/src/WebFormControlElement.cpp:35 > +#include "HTMLFormElement.h" nit: Why do you need to include this header here?
Darin Fisher (:fishd, Google)
Comment 4 2011-07-28 10:07:47 PDT
Comment on attachment 102229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102229&action=review >> Source/WebKit/chromium/src/WebFormControlElement.cpp:35 >> +#include "HTMLFormElement.h" > > nit: Why do you need to include this header here? he needs that so that the WebFormElement(const PassRefPtr<HTMLFormElement>&) constructor can be called. that requires the definition of the HTMLFormElement class.
WebKit Review Bot
Comment 5 2011-07-28 22:32:36 PDT
Comment on attachment 102229 [details] Patch Clearing flags on attachment: 102229 Committed r91975: <http://trac.webkit.org/changeset/91975>
WebKit Review Bot
Comment 6 2011-07-28 22:32:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.