Bug 65262

Summary: [skia] fix clipping of some glyphs on windows
Product: WebKit Reporter: Mike Reed <reed>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, junov, kbr, rniwa, senorblanco, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mike Reed
Reported 2011-07-27 09:14:21 PDT
[skia] fix clipping of some glyphs on windows
Attachments
Patch (2.85 KB, patch)
2011-07-27 09:16 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2011-07-27 09:16:27 PDT
Created attachment 102149 [details] Patch
Mike Reed
Comment 2 2011-07-27 09:18:33 PDT
These will be rebaselined after we roll to skia rev. 1960, which fixes some clipping issues. After that, we can process https://bugs.webkit.org/show_bug.cgi?id=65203
Stephen White
Comment 3 2011-07-27 11:46:36 PDT
Comment on attachment 102149 [details] Patch Looks good. r=me
WebKit Review Bot
Comment 4 2011-07-27 20:56:17 PDT
Comment on attachment 102149 [details] Patch Clearing flags on attachment: 102149 Committed r91897: <http://trac.webkit.org/changeset/91897>
WebKit Review Bot
Comment 5 2011-07-27 20:56:23 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 6 2011-07-27 23:38:15 PDT
This patch broke Chromium Windows (Tests): http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/17090/steps/layout-test/logs/stdio
Ryosuke Niwa
Comment 7 2011-07-27 23:48:47 PDT
Fixed in http://trac.webkit.org/changeset/91912.
Adrienne Walker
Comment 8 2011-07-28 09:15:56 PDT
(In reply to comment #7) > Fixed in http://trac.webkit.org/changeset/91912. mreed: Please run new-run-webkit-tests --lint-test-files when making test_expectations updates.
Note You need to log in before you can comment on or make changes to this bug.