Bug 65250

Summary: WebSocket: Pass the value of useHixie76Protocol flag to WebSocket object
Product: WebKit Reporter: Yuta Kitamura <yutak>
Component: WebCore Misc.Assignee: Yuta Kitamura <yutak>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 65247    
Attachments:
Description Flags
Patch none

Description Yuta Kitamura 2011-07-27 05:23:29 PDT 
To implement bug 65247, we need to determine the WebSocket protocol used by the WebSocketChannel associated with it.

WebSocket objects may reside in worker threads. WorkerContext does not provide the way to obtain Settings values, thus we need to get the value from WebSocketChannel (which is in the loader thread).
Comment 1 Yuta Kitamura 2011-07-27 06:35:47 PDT 
Created attachment 102141 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-07-27 08:43:08 PDT 
Comment on attachment 102141 [details]
Patch

This looks like a case where a bool is better than an enum, because callers don't use true/false literals, and there is no confusion.
Comment 3 WebKit Review Bot 2011-07-28 05:21:18 PDT 
Comment on attachment 102141 [details]
Patch

Clearing flags on attachment: 102141

Committed r91919: <http://trac.webkit.org/changeset/91919>
Comment 4 WebKit Review Bot 2011-07-28 05:21:23 PDT 
All reviewed patches have been landed.  Closing bug.