Bug 65246

Summary: [Qt][WK2] Clean WKPageLoaderClient
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebKit2Assignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2011-07-27 04:32:42 PDT
WKPageLoaderClient has empty functions after the refactorings, let's clean that.
Attachments
Patch (8.38 KB, patch)
2011-07-27 04:38 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-07-27 04:38:50 PDT
Created attachment 102124 [details] Patch
Andreas Kling
Comment 2 2011-07-27 04:54:54 PDT
Comment on attachment 102124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102124&action=review r=me > Source/WebKit2/UIProcess/qt/ClientImpl.cpp:116 > + QUrl qUrl = urlStr; > + toQtWebPageProxy(clientInfo)->updateNavigationActions(); > + toQtWebPageProxy(clientInfo)->didChangeUrl(qUrl); I don't really see the need for the qUrl variable here.
Benjamin Poulain
Comment 3 2011-07-27 06:12:44 PDT
Comment on attachment 102124 [details] Patch This qUrl is just adding clarity, no arm here :)
Andreas Kling
Comment 4 2011-07-27 06:29:24 PDT
(In reply to comment #3) > (From update of attachment 102124 [details]) > This qUrl is just adding clarity, no arm here :) If you hinsist :)
WebKit Review Bot
Comment 5 2011-07-27 06:55:20 PDT
Comment on attachment 102124 [details] Patch Clearing flags on attachment: 102124 Committed r91840: <http://trac.webkit.org/changeset/91840>
WebKit Review Bot
Comment 6 2011-07-27 06:55:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.