Summary: | [Qt] Fix tst_QWebElement::render() API test | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kristóf Kosztyó <kkristof> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED INVALID | ||||||||
Severity: | Normal | CC: | hausmann, jturcotte, ossy | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 38654 | ||||||||
Attachments: |
|
Description
Kristóf Kosztyó
2011-07-27 03:34:53 PDT
Kristóf, could you mark it as expected fail? Created attachment 102632 [details]
mark failing test cases as expected fail
FAIL! : tst_QWebElement::render() 'image2 == testImage' returned FALSE. () Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp(998)]
FAIL! : tst_QWebElement::render() 'chunk == image4.copy(chunkPaintRect)' returned FALSE. () Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp(1035)]
These testcases also fail
Comment on attachment 102632 [details]
mark failing test cases as expected fail
r=me
Comment on attachment 102632 [details] mark failing test cases as expected fail Landed in https://trac.webkit.org/changeset/92179 Created attachment 174134 [details]
Patch
This part of the testcase passes, but the other two still fail.
ping? Don't you want to decrease the number of failing API tests on the bots? Comment on attachment 174134 [details]
Patch
Thanks! rs=me
Comment on attachment 174134 [details] Patch Clearing flags on attachment: 174134 Committed r146872: <http://trac.webkit.org/changeset/146872> All reviewed patches have been landed. Closing bug. Reopen, because the bug is still valid, only the xfail patch landed. === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. |