Bug 65232

Summary: WebSocket: CloseEvent attribute is not available on WebWorkers in JSC
Product: WebKit Reporter: Yuta Kitamura <yutak>
Component: WebCore Misc.Assignee: Yuta Kitamura <yutak>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch v2 (updated ChangeLog) none

Yuta Kitamura
Reported 2011-07-26 22:28:07 PDT
CloseEvent isn't available from WebWorkers in JSC. V8 is not affected. We should have added [NoStaticTables] attribute in CloseEvent.idl.
Attachments
Patch (5.34 KB, patch)
2011-07-26 23:44 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Patch v2 (updated ChangeLog) (5.65 KB, patch)
2011-07-27 00:46 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2011-07-26 23:23:44 PDT
What I meant was "closeEvent.wasClean returns undefined in workers." Updated the bug summary.
Yuta Kitamura
Comment 2 2011-07-26 23:44:50 PDT
Created attachment 102096 [details] Patch
Kent Tamura
Comment 3 2011-07-26 23:55:05 PDT
Comment on attachment 102096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102096&action=review > Source/WebCore/ChangeLog:8 > + Add [NoStaticTables] attribute to CloseEvent interface definition. Would you explain why it fixes the problem please?
Yuta Kitamura
Comment 4 2011-07-27 00:46:09 PDT
Created attachment 102102 [details] Patch v2 (updated ChangeLog)
Kent Tamura
Comment 5 2011-07-27 00:49:32 PDT
Comment on attachment 102102 [details] Patch v2 (updated ChangeLog) Looks ok
WebKit Review Bot
Comment 6 2011-07-27 01:57:12 PDT
Comment on attachment 102102 [details] Patch v2 (updated ChangeLog) Clearing flags on attachment: 102102 Committed r91826: <http://trac.webkit.org/changeset/91826>
WebKit Review Bot
Comment 7 2011-07-27 01:57:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.