Bug 65196
| Summary: | WebCore::SynchronousLoaderClient::canAuthenticateAgainstProtectionSpace should ask FrameLoaderClient instead of blindly returning true | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Pratik Solanki <psolanki> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | achristensen, bfulgham, ddkilzer, psolanki |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Pratik Solanki
Code says
bool WebCoreSynchronousLoaderClient::canAuthenticateAgainstProtectionSpace(ResourceHandle*, const ProtectionSpace&)
{
// FIXME: We should ask FrameLoaderClient.
return true;
}
We should fix the FIXME. Corresponding code for CFNetwork based loader is being added in bug 65190.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alex Christensen
When this is fixed, we can fix the test from https://bugs.webkit.org/show_bug.cgi?id=159071 with WebKit1.