Bug 65185

Summary:

Web Inspector: move location conversion functions to SourceFile.

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Podivilov <podivilov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+

Pavel Podivilov

Reported 2011-07-26 07:50:20 PDT

Web Inspector: move location conversion functions to SourceFile. This is a step towards dealing with both pretty-print and compiler mappings uniformly in RawSource class (see https://docs.google.com/document/d/14AWiLDDxEuLaWuyG0X6deLRufrvxRu8HBP0LNJwvRZw/edit?hl=en_US&pli=1, https://bugs.webkit.org/show_bug.cgi?id=63940).

Attachments
Patch (15.20 KB, patch) 2011-07-26 07:51 PDT, Pavel Podivilov	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2011-07-26 07:51:35 PDT

Pavel Feldman

Comment 2 2011-07-28 06:17:43 PDT

Comment on attachment 102003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102003&action=review > Source/WebCore/inspector/front-end/SourceFile.js:55 > + rawLocationToUILocation: function(lineNumber, columnNumber) This should receive ScriptLocation (i.e. should not change).

Pavel Podivilov

Comment 3 2011-07-30 05:43:22 PDT

Note You need to log in before you can comment on or make changes to this bug.