Bug 65185

Summary: Web Inspector: move location conversion functions to SourceFile.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Description Pavel Podivilov 2011-07-26 07:50:20 PDT 
Web Inspector: move location conversion functions to SourceFile.

This is a step towards dealing with both pretty-print and compiler mappings uniformly in RawSource class (see https://docs.google.com/document/d/14AWiLDDxEuLaWuyG0X6deLRufrvxRu8HBP0LNJwvRZw/edit?hl=en_US&pli=1, https://bugs.webkit.org/show_bug.cgi?id=63940).
Comment 1 Pavel Podivilov 2011-07-26 07:51:35 PDT 
Created attachment 102003 [details]
Patch
Comment 2 Pavel Feldman 2011-07-28 06:17:43 PDT 
Comment on attachment 102003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102003&action=review

> Source/WebCore/inspector/front-end/SourceFile.js:55
> +    rawLocationToUILocation: function(lineNumber, columnNumber)

This should receive ScriptLocation (i.e. should not change).
Comment 3 Pavel Podivilov 2011-07-30 05:43:22 PDT 
Committed r92051: <http://trac.webkit.org/changeset/92051>