Bug 65185 - Web Inspector: move location conversion functions to SourceFile.
Summary: Web Inspector: move location conversion functions to SourceFile.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-26 07:50 PDT by Pavel Podivilov
Modified: 2011-07-30 05:43 PDT (History)
10 users (show)

See Also:

Attachments
Patch (15.20 KB, patch)
2011-07-26 07:51 PDT, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-07-26 07:50:20 PDT 
Web Inspector: move location conversion functions to SourceFile.

This is a step towards dealing with both pretty-print and compiler mappings uniformly in RawSource class (see https://docs.google.com/document/d/14AWiLDDxEuLaWuyG0X6deLRufrvxRu8HBP0LNJwvRZw/edit?hl=en_US&pli=1, https://bugs.webkit.org/show_bug.cgi?id=63940).
Comment 1 Pavel Podivilov 2011-07-26 07:51:35 PDT 
Created attachment 102003 [details]
Patch
Comment 2 Pavel Feldman 2011-07-28 06:17:43 PDT 
Comment on attachment 102003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102003&action=review

> Source/WebCore/inspector/front-end/SourceFile.js:55
> +    rawLocationToUILocation: function(lineNumber, columnNumber)

This should receive ScriptLocation (i.e. should not change).
Comment 3 Pavel Podivilov 2011-07-30 05:43:22 PDT 
Committed r92051: <http://trac.webkit.org/changeset/92051>