Bug 65143

Summary: [chromium] components/mac: Make webcore not depend on CoreAnimation
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, jamesr, sail, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Nico Weber
Reported 2011-07-25 15:50:35 PDT
[chromium] components/mac: Make webcore not depend on CoreAnimation
Attachments
Patch (1.74 KB, patch)
2011-07-25 15:51 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (1.60 KB, patch)
2011-07-25 16:05 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2011-07-25 16:08 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2011-07-25 16:13 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.57 KB, patch)
2011-07-25 16:14 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2011-07-25 15:51:58 PDT
Created attachment 101932 [details] Patch
James Robinson
Comment 2 2011-07-25 15:55:09 PDT
Comment on attachment 101932 [details] Patch Instead of #if 0 can you just delete these lines?
Sailesh Agrawal
Comment 3 2011-07-25 15:56:28 PDT
(In reply to comment #2) > (From update of attachment 101932 [details]) > Instead of #if 0 can you just delete these lines? Deleting the code makes it harder to merge with ScrollAnimatorMac.mm
James Robinson
Comment 4 2011-07-25 15:57:50 PDT
#ifdef !PLATFORM(CHROMIUM), then, since that's what we will probably want once we merge.
Nico Weber
Comment 5 2011-07-25 16:05:14 PDT
Created attachment 101935 [details] Patch
James Robinson
Comment 6 2011-07-25 16:07:23 PDT
Comment on attachment 101935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101935&action=review Thanks, that's better. R=me. When's the merge coming, btw? > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) You have to delete or edits this line before trying to check in, it'll fail an svn presubmit hook.
Nico Weber
Comment 7 2011-07-25 16:08:54 PDT
Created attachment 101937 [details] Patch
Nico Weber
Comment 8 2011-07-25 16:11:08 PDT
(In reply to comment #6) > (From update of attachment 101935 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101935&action=review > > Thanks, that's better. R=me. > > When's the merge coming, btw? sail: ^ > > > Source/WebCore/ChangeLog:8 > > + No new tests. (OOPS!) > > You have to delete or edits this line before trying to check in, it'll fail an svn presubmit hook.
Nico Weber
Comment 9 2011-07-25 16:13:40 PDT
Created attachment 101939 [details] Patch
Nico Weber
Comment 10 2011-07-25 16:14:36 PDT
Created attachment 101940 [details] Patch for landing
WebKit Review Bot
Comment 11 2011-07-25 18:04:50 PDT
Comment on attachment 101940 [details] Patch for landing Clearing flags on attachment: 101940 Committed r91733: <http://trac.webkit.org/changeset/91733>
WebKit Review Bot
Comment 12 2011-07-25 18:04:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.