Bug 65136

Summary:

simplify the UI of the header above the test list table

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

New Bugs

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, aroben, eric, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	abarth: review+

Description Ojan Vafai 2011-07-25 15:05:56 PDT

simplify the UI of the header above the test list table

Comment 1 Ojan Vafai 2011-07-25 15:07:00 PDT

Created attachment 101918 [details]
Patch

Comment 2 Adam Barth 2011-07-25 15:23:02 PDT

Comment on attachment 101918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101918&action=review

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2346
> +    var isTrue = g_currentState[key];

isTrue ?

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2347
> +    return '<label><input type=checkbox ' + (isTrue ? 'checked ' : '') + 'onclick="setQueryParameter(\'' + key + '\', ' + !isTrue + ')">' + text + '</label>';

/me advertises jQuery.  :)

Comment 3 Ojan Vafai 2011-07-25 15:32:52 PDT

Committed r91711: <http://trac.webkit.org/changeset/91711>