Bug 65131

Summary:

[chromium] incorrect vertex shader used when rendering video layer

Product:

WebKit

Reporter:

David Reveman <reveman>

Component:

WebCore Misc.

Assignee:

David Reveman <reveman>

Status:

RESOLVED FIXED

Severity:

Critical

CC:

jamesr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

David Reveman

Reported 2011-07-25 13:49:51 PDT

CCVideoLayerImpl is currently using the same vertex program as the tiler. This program uses a 'point' uniform to generate vertex coordinates but CCVideoLayerImpl never sets this uniform.

Attachments
Patch (5.44 KB, patch) 2011-07-25 13:55 PDT, David Reveman	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Reveman

Comment 1 2011-07-25 13:55:33 PDT

Created attachment 101904 [details] Patch

James Robinson

Comment 2 2011-07-25 14:07:45 PDT

Comment on attachment 101904 [details] Patch OK. We really should have some sort of test coverage to test this.

WebKit Review Bot

Comment 3 2011-07-25 16:27:41 PDT

Comment on attachment 101904 [details] Patch Clearing flags on attachment: 101904 Committed r91720: <http://trac.webkit.org/changeset/91720>

WebKit Review Bot

Comment 4 2011-07-25 16:27:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.