Bug 65127 – by default hide tests that have passes for all recorded runs

• Component: New Bugs
• Status: RESOLVED FIXED

[Ojan Vafai]

by default hide tests that have passes for all recorded runs

[Ojan Vafai]

Created attachment 101897 [details]
Patch

[Adam Barth]

Comment on attachment 101897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101897&action=review

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1360
> +            for (var i = 0; i < tests.length; i++)
> +                html += open + tests[i].test + '</div>';

This line probably has XSS

[Ojan Vafai]

(In reply to comment #2)
> (From update of attachment 101897 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101897&action=review
> 
> > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1360
> > +            for (var i = 0; i < tests.length; i++)
> > +                html += open + tests[i].test + '</div>';
> 
> This line probably has XSS

Yeah. There's a number of XSS holes in this code. There's not actually anything valuable at test-results.appspot.com though, so I'm loathe to spend the significant refactoring effort to fix these in cases where it's not trivial.

[Ojan Vafai]

Committed r91705: <http://trac.webkit.org/changeset/91705>