Bug 65122

Summary: [chromium] HUD texture must be unreserved after drawing
Product: WebKit Reporter: Vangelis Kokkevis <vangelis>
Component: WebCore Misc.Assignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kbr: review+

Vangelis Kokkevis
Reported 2011-07-25 10:59:14 PDT
The HUD texture is now allocated out of the RenderSurface manager whose textures don't get explicitly unreserved after drawing. As a result, we end up doing a double-reserve of the HUD texture which hits an ASSERT in debug builds.
Attachments
Patch (1.61 KB, patch)
2011-07-25 16:20 PDT, James Robinson 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-07-25 16:20:19 PDT
Created attachment 101941 [details] Patch
Kenneth Russell
Comment 2 2011-07-25 16:29:50 PDT
Comment on attachment 101941 [details] Patch Looks OK as long as it's been tested.
James Robinson
Comment 3 2011-07-25 16:31:21 PDT
I tested locally with and without this patch in debug. Thanks for the quick review.
James Robinson
Comment 4 2011-07-25 16:35:32 PDT
Committed r91722: <http://trac.webkit.org/changeset/91722>
Note You need to log in before you can comment on or make changes to this bug.