Bug 65113

Summary: Web Inspector: simplify Drawer.js
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED WONTFIX    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 68155    
Bug Blocks:    
Attachments:
Description Flags
Patch pfeldman: review-

Yury Semikhatsky
Reported 2011-07-25 08:49:54 PDT
Drawer can only contain ConsoleView but contains some logic assuming that it can contain other type of views. The code can be simplified.
Attachments
Patch (5.36 KB, patch)
2011-07-25 08:51 PDT, Yury Semikhatsky 		pfeldman: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-07-25 08:51:59 PDT
Created attachment 101875 [details] Patch
Pavel Feldman
Comment 2 2011-07-26 01:19:46 PDT
Comment on attachment 101875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101875&action=review > Source/WebCore/inspector/front-end/Drawer.js:59 > + WebInspector.console.show(); Drawer class should not depend on console object unless they are merged into a single entity.
Note You need to log in before you can comment on or make changes to this bug.