Bug 65096

Summary: [CSS Exclusions] Use HANDLE_INHERIT_AND_INITIAL when parsing -webkit-wrap-shape
Product: WebKit Reporter: Alexandru Chiculita <achicu>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alexandru Chiculita
Reported 2011-07-24 23:50:06 PDT
Fix for the feedback in comment #30 From Luke Macpherson on https://bugs.webkit.org/show_bug.cgi?id=61726 . (From update of attachment 99531 [details]) View in context: https://bugs.webkit.org/attachment.cgi?id=99531&action=review > Source/WebCore/css/CSSStyleSelector.cpp:5314 > + if (isInitial) { remove this whole if and use the HANDLE_INHERIT_AND_INITIAL(wrapShape, WrapShape) instead. > Source/WebCore/css/CSSStyleSelector.cpp:5318 > + if (!primitiveValue) return; here, and remove the later checks.
Attachments
Patch (5.18 KB, patch)
2011-07-25 00:49 PDT, Alexandru Chiculita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexandru Chiculita
Comment 1 2011-07-25 00:49:25 PDT
Created attachment 101853 [details] Patch
WebKit Review Bot
Comment 2 2011-07-25 11:02:15 PDT
Comment on attachment 101853 [details] Patch Clearing flags on attachment: 101853 Committed r91679: <http://trac.webkit.org/changeset/91679>
WebKit Review Bot
Comment 3 2011-07-25 11:02:19 PDT
All reviewed patches have been landed. Closing bug.
Luke Macpherson
Comment 4 2011-07-25 16:23:31 PDT
Looks good, thanks!
Note You need to log in before you can comment on or make changes to this bug.