Bug 65090

Summary: Small cleanup of m_fontDirty tracking in CSSStyleSelector
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, macpherson, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Luke Macpherson
Reported 2011-07-24 19:01:21 PDT
Small cleanup of m_fontDirty tracking in CSSStyleSelector
Attachments
Patch (8.84 KB, patch)
2011-07-24 19:07 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.23 KB, patch)
2011-07-24 21:12 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-07-24 19:07:06 PDT
Created attachment 101845 [details] Patch
Darin Adler
Comment 2 2011-07-24 20:13:08 PDT
Comment on attachment 101845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101845&action=review Please consider doing this without the name change. > Source/WebCore/ChangeLog:8 > + 1) Use exising setFontDescription helper where appropriate. Typo: existing > Source/WebCore/css/CSSStyleSelector.cpp:1997 > -void CSSStyleSelector::updateFont() > +void CSSStyleSelector::updateFontIfDirty() I don’t think we need the name change. It’s great to move the check into the function, even without changing the function name to make that explicit.
Luke Macpherson
Comment 3 2011-07-24 21:12:30 PDT
Created attachment 101848 [details] Patch for landing
WebKit Review Bot
Comment 4 2011-07-24 22:10:47 PDT
Comment on attachment 101848 [details] Patch for landing Clearing flags on attachment: 101848 Committed r91657: <http://trac.webkit.org/changeset/91657>
WebKit Review Bot
Comment 5 2011-07-24 22:10:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.