| Summary: | Remove inclusion of MainThread.h from Threading.h | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||||||
| Component: | New Bugs | Assignee: | Patrick R. Gansterer <paroga> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, dglazkov, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Patrick R. Gansterer
2011-07-24 11:40:34 PDT
Created attachment 101828 [details]
Patch
Comment on attachment 101828 [details] Patch Attachment 101828 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9234675 Comment on attachment 101828 [details]
Patch
Chromium build fails due to a file named CCLayerTreeHostImplProxy.cpp.
Created attachment 101831 [details]
Patch
Comment on attachment 101831 [details] Patch Attachment 101831 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9226774 Created attachment 101832 [details]
Patch
Comment on attachment 101832 [details] Patch Rejecting attachment 101832 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: dio/HRTFPanner.h:28, from Source/WebCore/platform/audio/Panner.cpp:36: Source/WebCore/webaudio/AudioContext.h: In member function 'void WebCore::AudioContext::incrementConnectionCount()': Source/WebCore/webaudio/AudioContext.h:145: error: 'isMainThread' was not declared in this scope make: *** [out/Debug/obj.target/webcore_platform/Source/WebCore/platform/audio/HRTFPanner.o] Error 1 make: *** [out/Debug/obj.target/webcore_platform/Source/WebCore/platform/audio/Panner.o] Error 1 Full output: http://queues.webkit.org/results/9228803 Created attachment 102431 [details]
Patch for landing
Comment on attachment 102431 [details] Patch for landing Clearing flags on attachment: 102431 Committed r92068: <http://trac.webkit.org/changeset/92068> All reviewed patches have been landed. Closing bug. I cleaned up the run-bindings-tests results in http://trac.webkit.org/changeset/92069 |