Bug 65055

Summary: [chromium] Remove code that attempted to explicitly sync compositing state before compositing
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, fishd, jbates, kbr, nduca, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kbr: review+

James Robinson
Reported 2011-07-22 16:11:20 PDT
[chromium] Remove code that attempted to explicitly sync compositing state before compositing
Attachments
Patch (3.35 KB, patch)
2011-07-22 16:15 PDT, James Robinson 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-07-22 16:15:01 PDT
Created attachment 101788 [details] Patch
James Robinson
Comment 2 2011-07-22 16:15:45 PDT
I'd like to get this for m14. Turns out this code is not useful like I hoped it would be and hurts framerate on some pages :(.
Kenneth Russell
Comment 3 2011-07-22 16:22:23 PDT
Comment on attachment 101788 [details] Patch This looks fine to me but testing is the only way to know whether this removal has any adverse side-effects.
James Robinson
Comment 4 2011-07-22 16:25:09 PDT
The layout tests and brief manual testing are happy, and we've added a lot of defensive code. If I'm wrong I guess we'll find out via crash reports! Thanks for the prompt review.
James Robinson
Comment 5 2011-07-22 16:38:13 PDT
Committed r91621: <http://trac.webkit.org/changeset/91621>
Note You need to log in before you can comment on or make changes to this bug.