Bug 65032

Summary: Improve (i.e., speed up) .gyp(i) files for Chromium
Product: WebKit Reporter: Viet-Trung Luu <viettrungluu>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, thakis, viettrungluu, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Viet-Trung Luu
Reported 2011-07-22 10:52:52 PDT
Improve (i.e., speed up) .gyp(i) files for Chromium
Attachments
Patch (54.91 KB, patch)
2011-07-22 10:58 PDT, Viet-Trung Luu 		no flags
DetailsFormatted DiffDiff
Patch (54.75 KB, patch)
2011-07-22 11:11 PDT, Viet-Trung Luu 		no flags
DetailsFormatted DiffDiff
Patch (106.39 KB, patch)
2011-07-22 11:30 PDT, Viet-Trung Luu 		no flags
DetailsFormatted DiffDiff
Patch (106.24 KB, patch)
2011-07-26 11:35 PDT, Viet-Trung Luu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Viet-Trung Luu
Comment 1 2011-07-22 10:58:11 PDT
Created attachment 101741 [details] Patch
Adam Barth
Comment 2 2011-07-22 11:04:56 PDT
Comment on attachment 101741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101741&action=review > Source/WebCore/WebCore.gypi:6974 > + # FIXME ?
WebKit Review Bot
Comment 3 2011-07-22 11:10:36 PDT
Comment on attachment 101741 [details] Patch Attachment 101741 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9230150
Viet-Trung Luu
Comment 4 2011-07-22 11:11:58 PDT
Created attachment 101742 [details] Patch
Viet-Trung Luu
Comment 5 2011-07-22 11:12:30 PDT
(In reply to comment #2) > (From update of attachment 101741 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101741&action=review > > > Source/WebCore/WebCore.gypi:6974 > > + # FIXME > > ? Oops, sorry about that.
WebKit Review Bot
Comment 6 2011-07-22 11:14:49 PDT
Comment on attachment 101742 [details] Patch Attachment 101742 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9233132
Viet-Trung Luu
Comment 7 2011-07-22 11:30:40 PDT
Created attachment 101745 [details] Patch
WebKit Review Bot
Comment 8 2011-07-22 12:42:31 PDT
Comment on attachment 101745 [details] Patch Clearing flags on attachment: 101745 Committed r91595: <http://trac.webkit.org/changeset/91595>
WebKit Review Bot
Comment 9 2011-07-22 12:42:36 PDT
All reviewed patches have been landed. Closing bug.
Viet-Trung Luu
Comment 10 2011-07-26 11:35:43 PDT
Created attachment 102033 [details] Patch
Viet-Trung Luu
Comment 11 2011-07-26 11:37:28 PDT
It was rolled out due to missing '../' in the source exclusion list for webcore_dom. Fixed now in new patch.
WebKit Review Bot
Comment 12 2011-07-26 12:37:14 PDT
Comment on attachment 102033 [details] Patch Clearing flags on attachment: 102033 Committed r91774: <http://trac.webkit.org/changeset/91774>
WebKit Review Bot
Comment 13 2011-07-26 12:37:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.