Bug 65007 – [Qt] Add option to turn on disk caching in QtTestBrowser

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Keith Kyzivat]

Some of the tests that we run test the disk caching.  While we're switching over to WK2, there is a desire to compare the results to WK1's QtTestBrowser.
This is a request to add basic QNAM QNetworkDiskCache caching to QtTestBrowser.

[Keith Kyzivat]

Created attachment 101694 [details]
Patch

[Noam Rosenthal]

Comment on attachment 101694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101694&action=review

> Tools/QtTestBrowser/launcherwindow.cpp:808
> +        qDebug() << "Using disk cache location: " << cacheLocation;
> +        cache->setCacheDirectory(cacheLocation);
> +    }
> +    page()->networkAccessManager()->setCache(cache);
> +    qDebug() << "disk cache" << (enable ? "enabled" : "disabled");

Please remove qDebug() before committing. Those tend to clutter after a while.

[Keith Kyzivat]

Created attachment 101734 [details]
patch

[WebKit Review Bot]

Comment on attachment 101734 [details]
patch

Clearing flags on attachment: 101734

Committed r91635: <http://trac.webkit.org/changeset/91635>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

Reopen, because it was rolled out by https://trac.webkit.org/changeset/91649

I rolled out this patch, because it broke the Qt minimal buildbot. Before you ask me, why I didn't try to fix it instead of rolling out: Because I won't do it instead of the author on a sunday night and the author must watch the buildbots on build.webkit.org and fix his patch if he break something.

[Csaba Osztrogonác]

You can find the build log here: http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/29415

[Keith Kyzivat]

Totally understandable Ossy. I'll fix it as soon as I get a chance to do a minimal build.

How can I prevent this sort of situation from happening in the future? Is there an early warning bot that runs the minimal build configuration that I'm not aware of?

[Csaba Osztrogonác]

(In reply to comment #8)
> Totally understandable Ossy. I'll fix it as soon as I get a chance to do a minimal build.
> 
> How can I prevent this sort of situation from happening in the future? Is there an early warning bot that runs the minimal build configuration that I'm not aware of?

You can find the configuration of the minial bot here: http://build.webkit.org/buildslaves/szeged-linux-2

Unfortunately we don't have EWS bot for minimal build now, but it is a good idea.

[Csaba Osztrogonác]

Eric, how can we add a new EWS platform for qt-minimal if we would like to do it?

[Keith Kyzivat]

Created attachment 101906 [details]
Patch

patch updated to work with Qt minimal build

[WebKit Review Bot]

Comment on attachment 101906 [details]
Patch

Clearing flags on attachment: 101906

Committed r91806: <http://trac.webkit.org/changeset/91806>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.