| Summary: | SelectionController's setters should notify delegates of selection changes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Garcia <justin.garcia> | ||||||||
| Component: | HTML Editing | Assignee: | Justin Garcia <justin.garcia> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | Graham.Dennis, ian | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 420+ | ||||||||||
| Hardware: | Mac | ||||||||||
| OS: | OS X 10.4 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 10340 [details]
patch w/o layout test changes
Not included in the patch is a layout test and changes to layout test results (nearly all editing layout tests have extra didChangeSelection calls from Selection changes that weren't reported before).
Created attachment 10341 [details]
patch w/o layout test changes
Created attachment 10344 [details]
patch w/o layout test changes
Comment on attachment 10344 [details]
patch w/o layout test changes
tim reviewed this
|
To get selection notifications sent to delegates, you have to call m_frame->setSelection(). This idiosyncrasy caused a layout test failure after maciej removed clearSelection() { m_frame->setSelection (SelectionController()) } and replaced calls to it with selection().clear(). Since it's non-obvious, and since I want to make the JS Selection Object a wrapper around a SelectionController and not an m_frame, I want to fix this.