Bug 64929
| Summary: | Web Inspector: support object notation in generated agents on front-end. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> |
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | apavlov, burg, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Pavel Feldman
Today:
var urlRegex = "debugger-set-breakpoint.*";
var lineNumber = 8;
var columnNumber = undefined;
var condition = undefined;
var isRegex = true;
DebuggerAgent.setBreakpointByUrl(url, lineNumber, columnNumber, condition, isRegex);
Desired:
DebuggerAgent.setBreakpointByUrl({ url: "debugger-set-breakpoint.*", lineNumber: 8, isRegex: true });
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Patrick Mueller
Are you planning on changing the APIs, or accepting object/properties as an alternative to the existing APIs?
Your example doesn't include a callback function. Will those be a property of the object parameter as well? I rather like the convention of having the callback function specified at the end of the parameter list.
Pavel Feldman
(In reply to comment #1)
> Are you planning on changing the APIs, or accepting object/properties as an alternative to the existing APIs?
>
> Your example doesn't include a callback function. Will those be a property of the object parameter as well? I rather like the convention of having the callback function specified at the end of the parameter list.
It should definitely stay:
DebuggerAgent.setBreakpointByUrl({ url: "debugger-set-breakpoint.*", lineNumber: 8, isRegex: true }, callback);