Bug 64899 – show a list of average test times in the treemap

• Component: New Bugs
• Status: RESOLVED FIXED

[Ojan Vafai]

show a list of average test times in the treemap

[Ojan Vafai]

Created attachment 101523 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 101523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101523&action=review

> Tools/TestResultServer/static-dashboards/treemap.html:206
> +        if (avgA > avgB)
> +            return -1;
> +        else if (avgA == avgB)
> +            return 0;
> +        else
> +            return 1;

It's simpler to say:

return avgB - avgA;

[Ojan Vafai]

(In reply to comment #2)
> (From update of attachment 101523 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101523&action=review
> 
> > Tools/TestResultServer/static-dashboards/treemap.html:206
> > +        if (avgA > avgB)
> > +            return -1;
> > +        else if (avgA == avgB)
> > +            return 0;
> > +        else
> > +            return 1;
> 
> It's simpler to say:
> 
> return avgB - avgA;

Whoops. I had it in my head that this was an issue in some cases, but that's only when strings are involved.

[Ojan Vafai]

Committed r91415: <http://trac.webkit.org/changeset/91415>