Bug 64877

Summary: [Qt] Adopt existing GraphicsContext3D members (part 1)
Product: WebKit Reporter: Andrew Wason <rectalogic>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57261, 64878    
Attachments:
Description Flags
adopt GraphicsContext3D members
noam: review-
update ChangeLog none

Andrew Wason
Reported 2011-07-20 10:10:59 PDT
This is part 1 of a 3 part migration for bug 57261 to migrate to GraphicsContext3DOpenGL.cpp for Qt. Part 1 adopts existing GraphicsContext3D members for Qt. Move member vars and their initialization, and the GraphicsContext3DInternal::reshape() method out of GraphicsContext3DInternal and into GraphicsContext3D where they will be used when we adopt GraphicsContext3DOpenGL.cpp
Attachments
adopt GraphicsContext3D members (21.97 KB, patch)
2011-07-20 10:42 PDT, Andrew Wason 		noam: review-
DetailsFormatted DiffDiff
update ChangeLog (22.19 KB, patch)
2011-07-21 07:03 PDT, Andrew Wason 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrew Wason
Comment 1 2011-07-20 10:42:22 PDT
Created attachment 101483 [details] adopt GraphicsContext3D members
Noam Rosenthal
Comment 2 2011-07-21 01:48:33 PDT
Comment on attachment 101483 [details] adopt GraphicsContext3D members View in context: https://bugs.webkit.org/attachment.cgi?id=101483&action=review The code changes are good. Please resubmit with a more informative ChangeLog. > Source/WebCore/ChangeLog:8 > + Existing webgl layout tests should test this. WebGL, not webgl. > Source/WebCore/ChangeLog:11 > + where they will be needed when we adopt GraphicsContext3DOpenGL.cpp Missing a period, this upsets some people :)
Andrew Wason
Comment 3 2011-07-21 07:03:20 PDT
Created attachment 101583 [details] update ChangeLog
Noam Rosenthal
Comment 4 2011-07-21 07:13:41 PDT
Comment on attachment 101583 [details] update ChangeLog LGTM
WebKit Review Bot
Comment 5 2011-07-21 08:12:19 PDT
Comment on attachment 101583 [details] update ChangeLog Clearing flags on attachment: 101583 Committed r91469: <http://trac.webkit.org/changeset/91469>
WebKit Review Bot
Comment 6 2011-07-21 08:12:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.