Bug 64849

Summary: [Refactoring] Shadow inclusion cache should be managed by ShadowContentSelector
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64072    
Attachments:
Description Flags
Patch
none
Patch none

Description Hajime Morrita 2011-07-20 00:11:06 PDT
This is another preparation for introducing TreeIterator
Comment 1 Hajime Morrita 2011-07-20 00:32:37 PDT
Created attachment 101432 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-07-20 09:23:11 PDT
Comment on attachment 101432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101432&action=review

This is a great clean-up!

> Source/WebCore/dom/ShadowContentSelector.h:61
> +    { }

This looks a bit weird. Perhaps move definition out of decl, include at the bottom of the header?
Comment 3 Hajime Morrita 2011-07-21 01:34:42 PDT
Comment on attachment 101432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101432&action=review

>> Source/WebCore/dom/ShadowContentSelector.h:61
>> +    { }
> 
> This looks a bit weird. Perhaps move definition out of decl, include at the bottom of the header?

Thanks for review, Dimitri!
I'll give a non-inlined definition then land.
Comment 4 Hajime Morrita 2011-07-21 01:36:48 PDT
Created attachment 101560 [details]
Patch
Comment 5 WebKit Review Bot 2011-07-21 02:39:52 PDT
Comment on attachment 101560 [details]
Patch

Clearing flags on attachment: 101560

Committed r91453: <http://trac.webkit.org/changeset/91453>
Comment 6 WebKit Review Bot 2011-07-21 02:39:56 PDT
All reviewed patches have been landed.  Closing bug.