Summary: | [Refactoring] Shadow inclusion cache should be managed by ShadowContentSelector | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||
Component: | DOM | Assignee: | Hajime Morrita <morrita> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 64072 | ||||||||
Attachments: |
|
Description
Hajime Morrita
2011-07-20 00:11:06 PDT
Created attachment 101432 [details]
Patch
Comment on attachment 101432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101432&action=review This is a great clean-up! > Source/WebCore/dom/ShadowContentSelector.h:61 > + { } This looks a bit weird. Perhaps move definition out of decl, include at the bottom of the header? Comment on attachment 101432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101432&action=review >> Source/WebCore/dom/ShadowContentSelector.h:61 >> + { } > > This looks a bit weird. Perhaps move definition out of decl, include at the bottom of the header? Thanks for review, Dimitri! I'll give a non-inlined definition then land. Created attachment 101560 [details]
Patch
Comment on attachment 101560 [details] Patch Clearing flags on attachment: 101560 Committed r91453: <http://trac.webkit.org/changeset/91453> All reviewed patches have been landed. Closing bug. |