| Summary: | [chromium] LayerRendererChromium shouldn't be a friend of RenderSurfaceChromium | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | enne, kbr, vangelis, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
James Robinson
2011-07-19 15:57:19 PDT
Created attachment 101404 [details]
Patch
Miscellaneous small cleanup. I have some follow-up plans in this area that will be a lot more interesting. Comment on attachment 101404 [details]
Patch
Looks fine to me.
Comment on attachment 101404 [details] Patch Rejecting attachment 101404 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1 Last 500 characters of output: irectory Updating working directory Processing patch 101404 from bug 64834. ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9209037 I am not good at this new changelog format, I deleted the "Reviewed by " line :/. Committed r91322: <http://trac.webkit.org/changeset/91322> |