Bug 64821

Summary: cleanup some of the PLATFORM logic in the flakiness dashboard
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64829    
Attachments:
Description Flags
Patch
none
Patch abarth: review+

Ojan Vafai
Reported 2011-07-19 13:40:10 PDT
cleanup some of the PLATFORM logic in the flakiness dashboard
Attachments
Patch (4.97 KB, patch)
2011-07-19 13:40 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (4.96 KB, patch)
2011-07-19 13:42 PDT, Ojan Vafai 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-07-19 13:40:43 PDT
Created attachment 101374 [details] Patch
Ojan Vafai
Comment 2 2011-07-19 13:42:21 PDT
Created attachment 101376 [details] Patch
Adam Barth
Comment 3 2011-07-19 15:26:12 PDT
Comment on attachment 101376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101376&action=review > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1688 > function realModifiers(modifierString) "real" modifiers? As opposed to fictions modifiers?
Ojan Vafai
Comment 4 2011-07-19 15:45:27 PDT
(In reply to comment #3) > (From update of attachment 101376 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101376&action=review > > > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1688 > > function realModifiers(modifierString) > > "real" modifiers? As opposed to fictions modifiers? Sigh. I know. The comment clarifies what it means. I tried and failed to think of a better name.
Ojan Vafai
Comment 5 2011-07-19 15:46:40 PDT
Committed r91312: <http://trac.webkit.org/changeset/91312>
Note You need to log in before you can comment on or make changes to this bug.