Bug 64818

Summary: Remove surfaceType() and texture() methods from Chromium video frame classes.
Product: WebKit Reporter: Andrew Scherkus <scherkus>
Component: New BugsAssignee: Andrew Scherkus <scherkus>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andrew Scherkus
Reported 2011-07-19 13:25:57 PDT
Remove surfaceType() and texture() methods from Chromium video frame classes.
Attachments
Patch (9.29 KB, patch)
2011-07-19 13:27 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
Patch (9.30 KB, patch)
2011-07-19 13:35 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrew Scherkus
Comment 1 2011-07-19 13:27:39 PDT
Created attachment 101369 [details] Patch
WebKit Review Bot
Comment 2 2011-07-19 13:30:11 PDT
Attachment 101369 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andrew Scherkus
Comment 3 2011-07-19 13:35:12 PDT
Created attachment 101372 [details] Patch
Andrew Scherkus
Comment 4 2011-07-22 10:33:12 PDT
cc'ing graphics-y folk
Kenneth Russell
Comment 5 2011-07-22 11:12:03 PDT
Comment on attachment 101372 [details] Patch Looks fine as long as it's been tested.
Andrew Scherkus
Comment 6 2011-07-22 11:34:25 PDT
Comment on attachment 101372 [details] Patch thanks for the review! yeah just getting rid of potentially-confusing dead code
WebKit Review Bot
Comment 7 2011-07-22 12:07:55 PDT
Comment on attachment 101372 [details] Patch Clearing flags on attachment: 101372 Committed r91584: <http://trac.webkit.org/changeset/91584>
WebKit Review Bot
Comment 8 2011-07-22 12:07:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.