Bug 64809

Summary: REGRESSION (r91114-r91116): fast/dom/error-to-string-stack-overflow.html failing on Windows 7 Release (Tests)
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, sam
Priority: P2 Keywords: LayoutTestFailure, MakingBotsRed, Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
URL: http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r91116%20(14820)/results.html
Attachments:
Description Flags
The patch aroben: review+

Adam Roben (:aroben)
Reported 2011-07-19 09:49:08 PDT
fast/dom/error-to-string-stack-overflow.html started failing on Windows 7 Release (Tests) between r91115 and r91116 (inclusive). http://trac.webkit.org/log/trunk?rev=91116&stop_rev=91115 http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r91114%20(14819)/results.html passed http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r91116%20(14820)/results.html failed
Attachments
The patch (1.70 KB, patch)
2011-07-19 14:49 PDT, Gavin Barraclough 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-07-19 12:21:44 PDT
investigating.
Gavin Barraclough
Comment 2 2011-07-19 14:41:23 PDT
I think this just needs new results. The test deliberately triggers a stack overflow, and doesn't catch it, so the error is printed to the console. Previously RangeError had the wrong prototype, and didn't convert the error into a useful error message, printing a blank line in the console. Since r91116 we inherit from Error correctly, and print the error to the console.
Adam Roben (:aroben)
Comment 3 2011-07-19 14:46:43 PDT
Thanks for the analysis, Gavin. Could you update the results by grabbing them from the bot? "webkit-patch rebaseline" might be the easiest way.
Gavin Barraclough
Comment 4 2011-07-19 14:49:54 PDT
Created attachment 101391 [details] The patch
Gavin Barraclough
Comment 5 2011-07-19 14:51:47 PDT
Fixed in r91305
Note You need to log in before you can comment on or make changes to this bug.